Delay error reporting of filename mismatch. #37987
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jseyfried (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I'm not sure how to test this, I can't find any example of tests which rely on cross compilation. |
When cross compiling with procedural macros, the crate loader starts by looking for a target crate, before trying with a host crate. Rather than emitting an error immediately if the host and target extension differ, the compiler should delay it until both attempts have failed. Fixes rust-lang#37899 r? @jseyfried
plietar
force-pushed
the
cross-proc-macro
branch
from
5bb6154 to
2cdde5a
Compare
|
📌 Commit 2cdde5a has been approved by |
|
I opened issue #37993 for tests. |
Delay error reporting of filename mismatch. When cross compiling with procedural macros, the crate loader starts by looking for a target crate, before trying with a host crate. Rather than emitting an error immediately if the host and target extension differ, the compiler should delay it until both attempts have failed. Fixes #37899
When cross compiling with procedural macros, the crate loader starts by
looking for a target crate, before trying with a host crate.
Rather than emitting an error immediately if the host and target
extension differ, the compiler should delay it until both attempts have
failed.
Fixes #37899